Re: msevior - r25767 - abiword/branches/ABI-2-6-0-STABLE/src/wp/ap/unix

On 02/27/2009 05:36 PM, cvs@abisource.com wrote:
> extern "C" GdkPixbuf *
> abi_widget_render_page_to_image(AbiWidget *abi, int iPage)
> {
> + //
> + // AbiWord counts from 0 but we let the caller count from 1.
> + //
> + iPage--;

And you are not checking the input?

Given that it is an API, it would be safer to check the input against
values <= 0

Hub
Received on Fri Feb 27 23:46:18 2009