Re: vincent - r31336 - in abiword/branches/gsoc2012dialogs/src/wp/ap: win xp

Vincent,

> Modified: abiword/branches/gsoc2012dialogs/src/wp/ap/xp/ap_Dialog_FormatFrame.h
> ===================================================================
> --- abiword/branches/gsoc2012dialogs/src/wp/ap/xp/ap_Dialog_FormatFrame.h 2012-06-06 18:00:13 UTC (rev 31335)
> +++ abiword/branches/gsoc2012dialogs/src/wp/ap/xp/ap_Dialog_FormatFrame.h 2012-06-07 16:15:34 UTC (rev 31336)
> @@ -184,6 +184,8 @@
> float borderThicknessLeft () const { return m_borderThicknessLeft; }
> float borderThicknessTop () const { return m_borderThicknessTop; }
> float borderThicknessBottom () const { return m_borderThicknessBottom; }
> + float getFrameWidth(void);
> + float getFrameHeight(void);

These two function should be "const". And you can inline the
implementation right here.

> Modified: abiword/branches/gsoc2012dialogs/src/wp/ap/xp/ap_Dialog_FormatTable.h
> ===================================================================
> --- abiword/branches/gsoc2012dialogs/src/wp/ap/xp/ap_Dialog_FormatTable.h 2012-06-06 18:00:13 UTC (rev 31335)
> +++ abiword/branches/gsoc2012dialogs/src/wp/ap/xp/ap_Dialog_FormatTable.h 2012-06-07 16:15:34 UTC (rev 31336)
> @@ -122,6 +122,8 @@
> bool getLeftToggled();
> GR_Image * getImage(void) { return m_pImage;}
> FG_Graphic * getGraphic(void) { return m_pGraphic;}
> + float getTableWidth(void);
> + float getTableHeight(void);

Same here.

Hub
Received on Thu Jun 7 18:28:04 2012