Re: ib - r30462 - abiword/trunk/src/af/ev/gtk2

On 11-11-17 5:46 AM, cvs@abisource.com wrote:

> Modified: abiword/trunk/src/af/ev/gtk2/ev_UnixToolbar.cpp
> ===================================================================
> --- abiword/trunk/src/af/ev/gtk2/ev_UnixToolbar.cpp 2011-11-17 13:34:52 UTC (rev 30461)
> +++ abiword/trunk/src/af/ev/gtk2/ev_UnixToolbar.cpp 2011-11-17 13:46:40 UTC (rev 30462)
> @@ -1312,7 +1312,8 @@
> _wd * wd = m_vecToolbarWidgets.getNthItem(k);
> UT_ASSERT(wd && wd->m_widget);
> gtk_widget_set_sensitive(wd->m_widget, !bGrayed);
> - gtk_widget_set_visible(wd->m_widget, !EV_TIS_ShouldBeHidden(tis));
> + if (EV_TIS_ShouldBeHidden(tis)) gtk_widget_hide(wd->m_widget);
> + else gtk_widget_show(wd->m_widget);
> }
> break;
>
Please at lest make the code readable like
if ()
   statement;
else
   statement;

(or better, add the braces which I'm all for)

I know C++ is not Python but indentation ads clarity to the code.

Thanks,

Hub
Received on Thu Nov 17 16:49:31 2011