Re: Patches for two bugs (word count and line breaking)

Could you attach a patch to the bugreport and include this analysis?
After that, poke this dev list again, so we can review it!

Thanks a lot!
  Marc

On Sat, 2011-10-29 at 13:07 -0400, Simon Larochelle wrote:
> I also looked into bug 13101 (line spacing has no effect, text always
> rendered with single line spacing). I tracked the problem to the
> function fp_Line::calcBorderThickness(void) which sets the line height
> without looking at the block properties. The fp_Line::setHeight()
> command in fp_Line::calcBorderThickness() was added in revision 28594
> (implementation of paragraph border drawing).
>
> Note that presently the program flow is
>
> 1) set line height in fp_Line::recalcHeight(fp_Run * pLastRun)
> 2) assign lines to a column in fb_ColumnBreaker::_breakSection(fp_Page
> * pStartPage)
> 3) set line height in fp_Line::calcBorderThickness(void)
> 4) set the position (m_iX and m_iY) of each line in
> fp_Column::layout(void)
>
> Clearly step 3 needs to be eliminated. Can we simply remove the line
> "setHeight(getAscent()+getDescent());" from
> fp_Line::calcBorderThickness setHeight() ?
>
>
> Simon
Received on Mon Nov 14 22:03:46 2011