Re: urmaslt - r29620 - abiword/trunk/plugins/mswrite/xp

On Fri, 2011-07-15 at 20:12 +0200, Ingo Brückl wrote:
> J.M. Maurer wrote on Fri, 08 Jul 2011 17:39:47 +0200:
>
> > could you help us out and point us to the relevant change(s) that
> > need to be made to get the plugin to work again?
>
> Here you are. Please see the attached patch.
>
> From the current codebase of the MSWrite plugin (based on last change made in
> r29667) there are some indent changes in read_pap() which blow up the patch.

Thanks so much for working on this!

> I started my work with the pre-r29620 codebase after having applied my
> original "complete support for all possible picture types" patch, examining
> all repository changes since then.
>
> The codepage code has been revised, greatly simplified and (to be worth the
> effort) completed by adding the missing font substitutes.
>
> Large parts of r29645 are reverted now and - instead - the whole
> header/footer stuff has been completely rewritten. (Who did that patch? I
> cannot remember having seen a patch proposal here.) The plugin now has *full*
> support of headers and footers, including page number, starting number,
> margins, formatting and appearance (or not) on the first page.
>
> Assuming that Abi the Ant isn't a real person,

Well, all we know of Abi is http://abisource.com/~abi/ :)

> I registered Sean and me as
> authors of the plugin. If someone else did some *major* work on the plugin
> prior to r28948 (couldn't find one in the log), then his/her name should be
> inserted between the two of us.
>
> As always, I did extensive testings and can ensure that everything works fine
> now. (Well, only if the patch gets applied exactly as it is this time. If
> there are issues, please tell me.)

Urmas found a (little) bug related to codepage conversions, so he
committed everything except that that part. If he can provide a sample
document, could you then look into this part? It would be nice if we
released 2.9.2 with a top notch MSWrite plugin.

Cheers!
  Marc
Received on Sat Jul 16 00:06:06 2011