Re: urmaslt - r29620 - abiword/trunk/plugins/mswrite/xp

Hi Ingo!

On Fri, 2011-07-08 at 16:29 +0200, Ingo Brückl wrote:
> Urmas wrote on Mon, 7 Mar 2011 01:20:17 +0600:
>
> > Now you don't want to continue discussion about *1 line of text*, do you?
>
> Maybe I feel like discussing about the MSWrite plugin *crashing* now
> in 2.9.1...
>
> Congratulation, guys, you managed to cripple my patch in a way that actually
> stopped the plugin from working.

Ick. Luckily you catched this in a development release, before we
released the next stable version.

> When I simply copy my patched 2.8.6 plugin source over 2.9.1, guess what
> happens...? The plugin just works fine again!
>
> Sorry for being sarcastic, but I spent lot of my spare leisure time to make
> this plugin work almost as good as the original MSWrite application and did
> some extensive testing only to see this time wasted.

I feel your pain; unfortunately it always gets messy really fast when
two people are working on the same codebase (which is what happened, if
I recall correctly).

> Kathiravelu Pradeeban wrote on Mon, 7 Mar 2011 00:34:19 +0530:
>
> > As I feel, Urmas, as the committer, can review and commit a part
> > or full of your patch. Usually we can't expect the entire patch to be
> > committed as it is. Since Urmas had to review the patch before
> > committing, he might have omitted a few code segments in doubt.
>
> You ought to respect the work of your voluntary developers. If changes are
> necessary, discuss them. In this particular case, no changes were necessary,
> something simply got screwed up.

Since I didn't follow the entire discussion in the past: could you help
us out and point us to the relevant change(s) that need to be made to
get the plugin to work again?

Or would that be too hard to track down, and do we need another
solution? If so, what would you say would be the best option?

If you need write access to the repository so you can make the changes
yourself, then that would be possible.

> Since the MSWrite plugin is very important to me and since I like to benfit
> from further developments like the epub plugin, I'm afraid I have to revise
> the current mess. But I'm not in the mood of doing so if I have to worry
> about this work again.

We very much appreciate all the effort you put into this already. It
would be great to have a working 2.9.2 release, so all your work does
not go to waste.

I do understand your frustration, and I apologize for the trouble. We
are all volunteers, and we all screw up from time to time. Sorry about
that.

Cheers,
  Marc
Received on Fri Jul 8 17:39:54 2011