Re: uwog - r27126 - abiword/trunk/src/wp/impexp/xp

On Sat, Jul 04, 2009 at 07:24:47PM +0200, J.M. Maurer wrote:
>
> > Works fine, but not everybody use Emacs, it is does not enforce the { }
> > or new line and thing like that. Nor does it reindent the existing stuff
> > automatically.
> >
> > Maybe we should write the definitive coding style for AbiWord, but I'm
> > sure some people won't be happy if we enforce it :-)
>
> We already have one, but people seem to love it when 10 different styles
> are used in 1 place.

My two (euro)cents:

I'm not heavily involved in abiword development, but hacked on it
occasionally, and would like to express my strongest support for having
one coding style and re-indenting existing code (the indent tool usually
does a good job there).

I didn't find the coding guidelines until now that I knew they existed.
A "HACKING" file seems to be pretty common in open-source projects,
maybe at least a pointer to AbiSourceCodeGuidelines.abw could be placed
there?

Otherwise, I'd recommend always expanding tabs to spaces (vim does this
with :set expandtabs). This way, code is readable for everyone without
knowing that 1 tab = 4 spaces.

Patrik