Re: msevior - r25523 - in abiword/trunk/src: text/fmt/xp wp/ap/xp wp/impexp/xp

On Thu, Jan 15, 2009 at 7:20 AM, J.M. Maurer <uwog@uwog.net> wrote:
>
> On Wed, 2009-01-14 at 14:00 +0100, cvs@abisource.com wrote:
>> + if(pContainer->getY() == -99999999)
>> + continue ; // container is not yet placed
>
> Magic numbers are bad: maybe an idea to make it a DEFINE somewhere?
>

Yes! You're right. I just fixed this and did a bit of consildation.

>> Modified: abiword/trunk/src/wp/ap/xp/ap_EditMethods.cpp
>> ===================================================================
>> --- abiword/trunk/src/wp/ap/xp/ap_EditMethods.cpp 2009-01-14
>> 02:10:00 UTC (rev 25522)
>> +++ abiword/trunk/src/wp/ap/xp/ap_EditMethods.cpp 2009-01-14
>> 13:00:38 UTC (rev 25523)
>> @@ -1637,7 +1637,7 @@
>> pLayout->updateLayout();
>> iPageCount = pLayout->countPages();
>>
>> - if(!s_bFirstDrawDone)
>> + if(!s_bFirstDrawDone && (iPageCount > 1))
>> {
>
> Shouldn't this be "iPageCount >= 1" ?
>

No I want more than one fully layed out page before drawing. It's a
good heuristic that the layotu is stable enough to draw to screen and
doesn't take a notible amount of extra time.

Thanks Marc!

Martin

> Cheers!
> Marc
>
>
Received on Thu Jan 15 00:04:41 2009