Re: Weird problems with Enchant and GTK

From: Enrico Tröger <enrico.troeger_at_uvena.de>
Date: Wed Aug 06 2008 - 12:28:22 CEST

On Sun, 3 Aug 2008 21:15:23 -0400, "Dominic Lachowicz"
<domlachowicz@gmail.com> wrote:

> The Zemberek provider uses dbus to talk to the Zemberek daemon. It
> probably doesn't unregister itself. It's also too permissive about
> what dictionaries it supports.
>
> If you have a little time, could you look into it? Code is here:
>
> http://www.abisource.com/viewvc/enchant/trunk/src/zemberek/zemberek_provider.cpp?view=markup

Attached is a little patch to skip the DBus Proxy setup if the initial
Dbus connection has failed. This isn't related to the original problem
but might be good anyway.

Another question: why is the whole error message handling commented out
in the zemberek code?

And finally, I'm pretty sure the t_type_init() isn't the problem. I
noticed, if I link the test app against the Glib-DBus libs, it works
nicely. Without it fails.
So, the whole thing is maybe only a bug in the build process rather
than in the code itself.

> zemberek_provider_request_dict should probably be modified to only
> return a dictionary if it can connect to the Zemberek dbus daemon and
> the language tag starts with "tr".

Yes, something like this should do the trick. I don't know much about
the zemberek server(?). But I'd like to see some improvements on this.
 
> http://www.abisource.com/viewvc/enchant/trunk/src/zemberek/zemberek.cpp?view=markup
>
> This has a "g_type_init" that it probably doesn't need.

You actually need this if the app (which is using libenchant.so)
doesn't have the GType system has initialised before. In other words,
GTK apps(abiword, ...) which use enchant wouldn't need this call but
other apps, maybe console apps actually need it.

Regards,
Enrico

-- 
Get my GPG key from http://www.uvena.de/pub.key

Received on Wed Aug 6 12:29:19 2008

This archive was generated by hypermail 2.1.8 : Wed Aug 06 2008 - 12:29:19 CEST