Re: rp - r21634 - in abiword-plugins/trunk/tools/abicollab: backends/tcp/win core/dialogs/win core/session/xp

On Sun, 2007-07-22 at 23:00 -0700, sum1_lists@yahoo.com wrote:
> > + AbiCollabSessionManager * pSessionManager=
> AbiCollabSessionManager::getManager();
> > + UT_return_if_fail(pSessionManager);
> > + m_hInstance=pSessionManager->getInstance();
> >
> [snip]
> > -
> > - vbox = gtk_vbox_new(FALSE, 6);
> > - GtkVBox* parent = (GtkVBox*)pEmbeddingParent;
> > + m_hServerEntry = CreateWindow("EDIT", "", ES_LEFT | WS_CHILD |
> WS_VISIBLE | WS_BORDER | WS_TABSTOP,
> > + 66, 71, 121, 14, m_hBox, NULL, m_hInstance, NULL);
>
> It looks like m_hInstance will be uninitialized if pSessionManager is
> NULL in the constructor above.

UT_return_if_fail in a constructor is scary enough :)

In rp's defence, if pSessionManager is NULL, then something is *really*
wrong. It's like XAP_App::getApp() returning NULL :)

Marc
Received on Mon Jul 23 10:43:45 2007