Re: jordimas - r21586 - in abiword/trunk/src: af/xap/xp wp/ap/win

J.M. Maurer wrote:
> On Wed, 2007-07-11 at 18:33 +0200, Jordi Mas wrote:
>
>>> So the 65 integer compares are the problem? Or am I missing something
>>> really obvious?
>>> I guess my issue with your solution is that it only is guaranteed to
>>> work if someone happens to test a debug version, notices the error, and
>>> actually fixes it. If no debug version is tested before a release, then
>>> the behavior might be wrong. This all to save 65 int compares.
>>>
>> They way that I did it is the way that I like it. I explained why. I obviously
>> have an emotional attachment to my solution since I wrote it :)
>>
>
> If you love your baby, we'll keep it :) The most important thing is that
> the bug that prevented Ryan from implementing some windows dialogs is
> actually fixed now.
>
> Thanks!
> Marc
>
Should I be adding a DEBUG build as a part of my release build process,
to check for errors like these? Are there other places in the code
where a similar "break in debug if it's broken" check is in place?

Ryan

-- 
Ryan Pavlik
AbiWord Win32 Platform Maintainer, Art Lead: www.abisource.com
AbiWord Community Outreach Project: www.cleardefinition.com/oss/abi/blog/
"Optimism is the father that leads to achievement."
 -- Helen Keller
"The folder structure in a modern Linux distribution such as Ubuntu
was largely inspired by the original UNIX foundations that were
created by men with large beards and sensible jumpers."
 -- Jono Bacon, The Ubuntu Guide