Re: load time regression: Re: commit: Change Record UUID's

>
> This commit causes a major speed regression
> when importing RTF files.
>
> E.g. RTF-1.5-Spec.RTF load time increases from 35s to 75s in my tests.
> Johnny Lee ( http://www.geocities.com/typopl/bug5291) measures a similar
> regression.
>
> Can we please remove this code for 2.4.x, as the uuids are not
> used anywhere yet ( as gocollab is more a 2.6 projekt).
>

Hmm This is a very good point. Tomas why do we need such a complex
structure? In fact I think we need just a simple counter that increments
with every change record created.

Something like m_myUID = PD_Document::getUID(CHangeRecord)

Cheers

martin

> Regards,
>
> Robert
>
>
>
> On Tue, 2005-06-14 at 16:28 +1000, Martin Sevior wrote:
>>
>> CVS:
>> ----------------------------------------------------------------------
>> CVS: Enter Log. Lines beginning with `CVS:' are removed automatically
>> CVS:
>> CVS: Committing in .
>> CVS:
>> CVS: Modified Files:
>> CVS: src/af/util/win/ut_Win32Uuid.h src/af/util/xp/ut_uuid.cpp
>> CVS: src/af/util/xp/ut_uuid.h src/text/ptbl/xp/px_ChangeRecord.cpp
>> CVS: src/text/ptbl/xp/px_ChangeRecord.h
>> CVS:
>> ----------------------------------------------------------------------
>> UUID's for Change Records. Code from Tomas Frydrich. Tested on unix by
>> me.
>>
>> We need these for abicollab. The code is small and well-contained. I've
>> found no regressions (not did I expect any).
>>
>> Martin
>>
>>
> --
> Robert Wilhelm <robert.wilhelm@gmx.net>
>
>
Received on Sat Oct 15 03:33:50 2005