Commit (HEAD): Fix PD_Style::isList() and remove related workarounds in EV_UnixToolbar

Cheers,
- Rob

Checking in text/ptbl/xp/pd_Style.cpp;
/cvsroot/abi/src/text/ptbl/xp/pd_Style.cpp,v <-- pd_Style.cpp
new revision: 1.28; previous revision: 1.27
done
Checking in text/ptbl/xp/pd_Style.h;
/cvsroot/abi/src/text/ptbl/xp/pd_Style.h,v <-- pd_Style.h
new revision: 1.22; previous revision: 1.21
done
Notifying #commits on irc.freenode.net...done.
Checking in af/ev/unix/ev_UnixToolbar.cpp;
/cvsroot/abi/src/af/ev/unix/ev_UnixToolbar.cpp,v <-- ev_UnixToolbar.cpp
new revision: 1.136; previous revision: 1.135
done
Checking in af/ev/unix/ev_UnixToolbar.h;
/cvsroot/abi/src/af/ev/unix/ev_UnixToolbar.h,v <-- ev_UnixToolbar.h
new revision: 1.31; previous revision: 1.30
done
Notifying #commits on irc.freenode.net...done.

On 5/20/05, msevior@physics.unimelb.edu.au
<msevior@physics.unimelb.edu.au> wrote:
>
> >
> > Hi Rob,
> >
> > Robert Staudinger wrote:
> >> Hi,
> >>
> >> while working at the new gtk combos i noticed a problem related to
> >> PD_Style::isList().
> >> It returns TRUE even when "list-style:None" is set. I'm proposing the
> >> attached (very simple) patch to the list because of the feature freeze
> >> and because this is very central in abiword. Caching of the list
> >> attribute is also removed because the cache is never reset, so it
> >> might lead to inconsistencies when changing the style (i read through
> >> the source code, this should not be called frequently anyways).
> >
> > This looks like the best solution to the bug; keeping the cache uptodate
> > is not simple because of the nested nature of styles, and this function
> > is only used once when merging APs in the varset, so as Rob said,
> > expanding the styles should not singificantly impact performance.
> >
> > The one thing that needs to be changed is the return values; boolean
> > functions should not return ints, i.e.,
> >
> > return UT_stricmp() != 0; and return false;
> >
> > Otherwise I think this should be commited, although I would prefer if
> > Martin had a look at it -- he knows all that is to be known about lists.
>
> I have looked at it too. I also prefer the
>
> return UT_stricmp() != 0;
>
> variant.
>
> I think that this code will work. Go ahead and commit.
>
> Martin
>
>
> >
> > Tomas
> >
> >
> >
> >
>
>
Received on Fri May 20 21:40:07 2005