> Just for the record: who approved this commit ? We
> are in feature
> freeze, and is it quite a UI change to make without
> any discussion.
I approved the commit. The change does not add or
remove a feature (i.e. providing an example of the
font's style to the user), it merely changes the form
of that feature.
Additionally, it might be considered a bugfix for at
least two reasons:
1) GtkCombo and GtkOptionMenu are deprecated. We
shouldn't use deprecated Widgets.
2) The toolbar combo boxes aren't editable, nor do
they appear to be editable. This is a UI improvment.
Finally, I think that Rob's work is more aesthetically
pleasing, and thus should be considered "UI polish".
I think that all these reasons are good reasons for
committing Rob's patch, and why I said "yes" when he
asked me if it was ok.
So, don't blame Rob for anything. He asked for
permission, and I said it was ok. If you need to blame
someone, blame me.
Best,
Dom
__________________________________
Yahoo! Mail Mobile
Take Yahoo! Mail with you! Check email on your mobile phone.
http://mobile.yahoo.com/learn/mail
Received on Mon May 9 19:45:05 2005
This archive was generated by hypermail 2.1.8 : Mon May 09 2005 - 19:45:05 CEST