Re: Commit (STABLE): Re: commit: New method to repair

>
> Great fix. Maybe we should add a debug msg or assert when this kicks in,
> so we at least know there is a problem somewhere.
>

Yes. I agree.

Martin

> Marc
>
> Backport: New method to stop repair import mistakes.
> "appendBlockIfNeeded" (msevior)
>
> CVS:
> ----------------------------------------------------------------------
> CVS: Enter Log. Lines beginning with `CVS:' are removed automatically
> CVS:
> CVS: Committing in .
> CVS:
> CVS: Modified Files:
> CVS: Tag: ABI-2-2-0-STABLE
> CVS: ./src/text/ptbl/xp/pd_Document.cpp
> CVS: ./src/text/ptbl/xp/pd_Document.h
> CVS:
> ----------------------------------------------------------------------
>
>
>
> Op wo, 09-02-2005 te 10:47 +1100, schreef
> msevior@physics.unimelb.edu.au:
>>CVS:
>> ----------------------------------------------------------------------
>>CVS: Enter Log. Lines beginning with `CVS:' are removed automatically
>>CVS:
>>CVS: Committing in .
>>CVS:
>>CVS: Modified Files:
>>CVS: src/text/ptbl/xp/pd_Document.cpp
>>CVS: src/text/ptbl/xp/pd_Document.h
>>CVS:
>> ----------------------------------------------------------------------
>>New method to stop repair import mistakes. "appendBlockIfNeeded"
>>
>>This should be BAKCPORTED.
>>
>>This method simply looks at the last frag in the document. If it's a
>> strux
>>and it's not a Block, EndFootnote or EndEndnote, this method appends a
>>block onto the PT.
>>
>>This method is called in appendSpan(..), appendObject(...),
>> appendFmt(...)
>>before ther span, object or fmt is appended onto the PT.
>>
>>This method will therefore correct the crashes we get when an importer
>>screws up something and puts some content after a non-block strux.
>>
>>The cost is trivial, we simply grab a pointer and examine it.
>>
>>This method fixes a crash I got importing an RTF file because of an open
>>Frame strux.
>>
>>Dom suggested we do something like this ages ago and we should have.
>>
>>Anyway, better late than never.
>>
>>Cheers
>>
>>Martin
>>
>
>
Received on Fri Feb 11 22:11:16 2005