Re: commit (head): 8393

On Sat, 2005-04-09 at 16:33 +0100, Tomas Frydrych wrote:
>
> This should fix 8393. I had to change the parameter in two of the
> XAP_Dialog_Language functions from UT_UTF8String to UT_String.

This is wrong: UT_String should be avoided AT ALL COST.
What should have been done is changing
        s = pSS->getValue(...);
By
        s = pSS->getValueUTF8(...);

> The Win32
> dlg is fixed up to reflect that; I have committed changes to the *nix
> dialogue which should be fine, but they are untested (I have not
> succeeded building libgnomeprintui on my machine and run out of time).
> The changes on Mac I will leave to Frank (are there any other characters
> in Objective-C than [ and ]?).

Cocoa use UTF-8 natively

>
> This whole lot should be backported.
>
> files: xap_Dialog_Language.h/cpp, xap_UnixDialog_Language.cpp,
> xap_Win32Dialog_Language.cpp.

Please don't backport. I'll fix that *differently and BETTER*

Hub

-- 
Crazy French - http://www.figuiere.net/hub/