Re: patch review

From: <msevior_at_physics.unimelb.edu.au>
Date: Thu Nov 11 2004 - 01:06:12 CET

>
> I've "fixed" bug 7389 with a patch attached to the bug
> http://bugzilla.abisource.com/attachment.cgi?id=2496&action=view
>
> I have no committed it because this revert a change beetween version
> 1.314 and 1.315 in ie_imp_RTF.cpp that Tomas did. The commit message is
> clear "rtf fixes". I don't want to break some other stuff, but I'm sure
> that what I did is right.
>
> Can anyone comment ? (Tomas)
>
> Bug 7389 has been retargetted for 2.2.x, but since I don't have any 2.2
> bug, I took it.
>

Hi Hub,
       Check that you don't add an extra paragraph break to every single
HdrFtr before committing.

Otherwise we need to be a bit cleverer about when to put the block strux in.

Cheers

Martin

> Hub
> --
> Crazy French - http://www.figuiere.net/hub/
>
>
Received on Thu Nov 11 01:04:58 2004

This archive was generated by hypermail 2.1.8 : Thu Nov 11 2004 - 01:04:58 CET