Re: commit (head)

My appologies and thanks to Martin for fixing the build.

Tomas,

who is cursing MSVC for not rejecting this

Subject: Re: commit (head)
From: "J.M. Maurer" <j.m.maurer@student.utwente.nl>
To: Tomas Frydrych <tomasfrydrych@yahoo.co.uk>
Copies to: abiword-dev@abisource.com
Date sent: Tue, 17 Aug 2004 23:34:48 +0200

> then mv -f ".deps/xad_Document.Tpo" ".deps/xad_Document.Po"; else rm -f
> ".deps/xad_Document.Tpo"; exit 1; fi
> xad_Document.cpp: In member function `virtual void
> AD_Document::setAutoRevisioning(bool)':
> xad_Document.cpp:670: error: `PD_MAX_REVISION' undeclared (first use
> this function)
> xad_Document.cpp:670: error: (Each undeclared identifier is reported
> only once for each function it appears in.)
>
>
> Marc
>
> On di, 2004-08-17 at 20:50 +0100, Tomas Frydrych wrote:
> >
> > This commit consits of two things:
> >
> > (a) removal of 0xffffffff values from the revision handling
> > I have defined value PD_MAX_REVISION (0x0fffffff) to be used in place
> > of the previously hardwired 0xffffffff in the revisions code.
> >
> > files: number in ie, text and xap.
> >
> > (b) refactoring of looking up properties by classes derived from
> > fl_ContainerLayout:
> >
> > I added fl_ContainerLayout::lookupProperties() and virtual
> > fl_ContainerLayout::_lookupProperties(const PP_AttrProp*) = 0. The
> > former processes common properties (such as folded level) and handles
> > revision-related visibility and then calls _lookupProperties(); the
> > latter is implemented by the derived classes and processes the class
> > specific properties. The virtual function should never be called
> > outside of fl_ContainerLayout::lookupProperties(); where we used to
> > call _lookupProperties() we now call lookupProperties() instead. This
> > fixes 7167 and probably some other bugs, and singnificantly improves
> > maintainability.
> >
> > files: various fl_*.h/cpp
> >
> >
> > Tomas
> >
>
Received on Wed Aug 18 10:04:30 2004