Subject: Re: Bugfix 2591 please commit
From: Tomas Frydrych (tomas@frydrych.uklinux.net)
Date: Fri Feb 01 2002 - 12:10:22 CST
committed, thanks.
Tomas
P.S. I did not have a chance to compile on Linux (my monitor just
died and I will have to reconfigure X for the ancient 14in monitor that
had to take its place).
> Fix for Bugzilla Bug 2591
> (Columns setup measure unit is always inches)
>
> What this does:
>
> in ut_units.cpp
> UT_reformatDimensionString
> Catch nulls, convert them to 0.0in, print debug msg.
> This prevents a segfault.
>
> in ap_UnixDialog_Columns.cpp
> Just changed the code formatting.
>
> in ap_Dialog_Columns.cpp
> add function _convertToPreferedUnits
> uses function to convert units to the same
> units set in the prefs.
>
> Note:
> This calls UT_reformatDimensionString which
> returns a pointer to a local string. Because
> the convert function gets called back to back
> in this file, you need to copy the data out
> of that local before hitting it again, hence
> the UT_XML_strncpy and setting of the parameter
> pRet.
>
> in ap_Dialog_Columns.h
> modifications necessary to support changes to
> the .cpp file.
>
>
> -
> Rob Altenburg
>
This archive was generated by hypermail 2b25 : Fri Feb 01 2002 - 12:11:58 CST