Subject: Re: Unnecessary constructor for each UT_UCS_strcpy_char
From: Dom Lachowicz (dominicl@seas.upenn.edu)
Date: Mon Sep 24 2001 - 13:29:45 CDT
Quoting Matti Picus <matti@picus.org>:
> UT_UCS_strcpy_char instantiates a UT_Mbtowc class instance on each
> call. As the default constructor uses values that should remain
> constant
> throughout the lifetime of the application, creating and destroying the
> UT_Mbtowc instance is unnecessary. Especially in a function as
> frequently
> used as UT_USC_strcpy_char. Here is a patch to make the variable static
> (created only once). Could someone review this and (hopefully) check it
> in?
> Thanks,
> Matti
Great catch. Committed.
Dom
This archive was generated by hypermail 2b25 : Mon Sep 24 2001 - 13:29:50 CDT