Subject: Windows specific patch: do not propagate a handled message
From: Matti Picus (matti@picus.org)
Date: Sat Sep 22 2001 - 14:50:56 CDT
The following patch reduces the number of times a language change message
is handled, since the frame handles it, the frame should not dispatch the
message further. Before the patch, setting a debugging breakpoint in the
message handler caused the app to continuously repost the message. In the
best case, the message was handled twice by the same frame.
Could someone review this patch and (hopefully) check it in?
Thanks,
Matti
Index: abi/src/af/xap/win/xap_Win32Frame.cpp
===================================================================
RCS file: /cvsroot/abi/src/af/xap/win/xap_Win32Frame.cpp,v
retrieving revision 1.72
diff -c -r1.72 xap_Win32Frame.cpp
*** abi/src/af/xap/win/xap_Win32Frame.cpp 2001/09/17 13:45:58 1.72
--- abi/src/af/xap/win/xap_Win32Frame.cpp 2001/09/22 18:30:43
***************
*** 600,608 ****
ev_Win32Keyboard *pWin32Keyboard = static_cast<ev_Win32Keyboard
*>(f->m_pKeyboard);
pWin32Keyboard->remapKeyboard((HKL)lParam);
! // We must propagate this message.
! return DefWindowProc(hwnd, iMsg, wParam, lParam);
}
case WM_MOUSEWHEEL:
--- 600,608 ----
ev_Win32Keyboard *pWin32Keyboard = static_cast<ev_Win32Keyboard
*>(f->m_pKeyboard);
pWin32Keyboard->remapKeyboard((HKL)lParam);
! // Do not propagate this message.
! return 1; //DefWindowProc(hwnd, iMsg, wParam, lParam);
}
case WM_MOUSEWHEEL:
This archive was generated by hypermail 2b25 : Sat Sep 22 2001 - 14:18:03 CDT