Re: Patches so Win32 BIDI version will build

Subject: Re: Patches so Win32 BIDI version will build
From: Tomas Frydrych (tomas@frydrych.uklinux.net)
Date: Tue Sep 18 2001 - 10:38:31 CDT

• sorted by: [ date ] [ thread ] [ subject ] [ author ]
• Next message: Martin Sevior: "commit: Some little lists work (1)."
• Previous message: David Mandelin: "[PATCH] Win32 idle loop"
• In reply to: Kenneth J.Davis: "Patches so Win32 BIDI version will build"
• Reply: Tomas Frydrych: "Re: Patches so Win32 BIDI version will build"

Hi Jeremy,

> Attached are some patches that will make the Win32 bidi version to build
> (using VC5).

Thanks, and thanks to Michael for committing this.

> fp_TextRun.cpp.patch : changed getMirrorChar to use fribidi_get_mirror_char.
> This may not be correct (they seemed like they did the same thing, but
> maybe not),

That's OK; we could in fact get rid off getMirrorChar completely,
and replace the single call to it with call to fribidi_get_mirrir_char
(getMirrorChar is a leftover from the way things were before using
fribidi).

> (By the way, I have it setup to automatically upload the tinderbox binaries
> to http://www.darklogic.org/win32/abiword/ at 10 EST for normal build, and
> 11 EST for bidi build (am & pm - latest available successful build)).

This is really great. Thanks.

Tomas

• Next message: Martin Sevior: "commit: Some little lists work (1)."
• Previous message: David Mandelin: "[PATCH] Win32 idle loop"
• In reply to: Kenneth J.Davis: "Patches so Win32 BIDI version will build"
• Reply: Tomas Frydrych: "Re: Patches so Win32 BIDI version will build"

This archive was generated by hypermail 2b25 : Tue Sep 18 2001 - 17:53:15 CDT