Subject: Re:[4] Win32 version dying on startup [fix maybe]
From: Kenneth J.Davis (jeremyd@computer.org)
Date: Thu Nov 08 2001 - 11:02:54 CST
Hi again,
Ok I played with the stack settings (using the linker option to increase
the PE stack size by a factor of 16 (0x10) and it made no effect.
However, I realized if I changed my hacks in
bool EV_Win32Menu::synthesizeMenu(XAP_Frame * pFrame, HMENU menuRoot) and
bool EV_Win32Menu::onInitMenu(XAP_Frame * pFrame, AV_View * pView, HWND hWnd, HMENU hMenuBar)
from
const EV_Menu_Action * pAction = pMenuActionSet->getAction(id);
/* kjd */ if (!pAction) break;
to
const EV_Menu_Action * pAction = pMenuActionSet->getAction(id);
/* kjd */ if (!pAction) continue;
^^^
then not only do I get a build that starts, but one that shows all*
the menus and seems to work. I say all*, because I think it is actually
missing the new bookmark related menu items, which I believe around the
day it stopped working were moved from the debug build only and also into
the release build, however the latest working copy I have doesn't have
them, so in comparison all the menus seem to be there.
My first impressions are that some of the initialization for them is
still behind an #ifdef DEBUG construct, but I haven't seen anything to
confirm this. And perhaps they aren't supposed to be there yet, I'm
just going on the fact the #ifdef DEBUG was removed from their ids.
Ok looked some more and sure enough,
MenuItem(AP_MENU_ID_INSERT_BOOKMARK)
MenuItem(AP_MENU_ID_INSERT_HYPERLINK)
were now now not protected by #ifdef DEBUG in ap_Menu_Layouts_MainMenu.h
but in ap_Menu_ActionSet.cpp they were, so pAction was NULL causing
the fault. I still need to do some verification (recompile with
a clean tree in case I have some other changes in my trying/testing
that are effecting this), but I believe removing the particular
#ifdef DEBUG in ap_Menu_ActionSet.cpp will fix it. And if no one
beats me to it, I will submit a patch once I verify it works in
a clean tree (in a couple hours or so).
Thank you,
Jeremy Davis
jeremyd@computer.org
This archive was generated by hypermail 2b25 : Thu Nov 08 2001 - 11:13:53 CST