Subject: Re: ZAP/[patch] Martin's cursor position POW
From: John L. Clark (jlc6@po.cwru.edu)
Date: Thu Jan 25 2001 - 07:15:41 CST
On Thu, Jan 25, 2001 at 10:16:04PM +1100, Martin Sevior wrote:
> HI John,
> I've read through your patch. I like the nice clean code although
> as Sam says it does not conform to the Abi style.
Heh, I'm just a code minimalist. I don't think code should take up more
space than necessary. ;-) I checked the guidelines in .../abi/doc, and
I didn't see anything about what Sam mentioned, but it's fine by me. I
just need to get acclimated to the rules. I'm still new here.
> Unfortunately I
> got strnge behaviour when I applied it. It might be because I was very
> rushed at the time. However reading through the code it looks like it
> should work and since Sam and you both say it does I suspect I did
> something wrong.
>
> Specifically I openned two views on a large document put the cursor near
> the end of one view and did a big cut near the beginning of the other
> view. The cursor in the uncut view jumped back to match the location in
> cut view. Did you check that all the _setpoint() functions were fixed in
> the doclisteners?
Could you send me the large document and let me know what you cut out at
the beginning so I can look at it? I may indeed have missed one of the
doclisteners.
>
> Anyway can you provide a new patch that conforms to the Abi style? I know
> it sounds silly but it does help in the longrun to have nice looking code.
>
> I'll have another go in a less rushed way with your new patch.
>
> Oh one last thing, instead of "unsigned int" use our platform independent
> "UT_uint32" declaration.
Ok, I just noticed "unsigned int" elsewhere in the code, so I copied it.
I'll make the change.
As far as commenting the function goes, is there a brief document on
writing comments in doxygen style anywhere in our source tree?
Take care,
John
This archive was generated by hypermail 2b25 : Thu Jan 25 2001 - 07:15:35 CST