Subject: Re: Win32 Tinderbox Breakage
From: F J Franklin (F.J.Franklin@sheffield.ac.uk)
Date: Thu Jan 25 2001 - 04:39:48 CST
On Wed, 24 Jan 2001, Sam TH wrote:
> So, now we have a real build problem. ms-ole.c complains about the
> inclusion of unistd.h in wv. Strangely enough, this is wrapped in a
> _HAVE_UNISTD_H ifdef. However, this file is included twice in the .c
> file, and I suspect this may be the cause of the breakage.
Okay, slight revision to earlier patch which fixes this as well.
=====
Can I just add, as a general comment, that "config.h" is very often
application specific and should not be visible to independent packages.
For one thing, since all the defs have standard names there can be
conflicts when one config.h defines
#define HasPNG
and another config.h defines
#define HasPNG 1
for example.
For another, the config.h represents the configuration at the
time configure was run, so the presence of old, visible config.h files
littering the system is highly undesireable.
Finally, config.h often has additional defines unrelated to the usual
tests, and including the wrong one will miss these.
For certainty, there should always be only one config.h in the include
path...
Regards, Frank
<fjf@alinameridon.com>
Francis James Franklin
F.J.Franklin@shef.ac.uk
Diodorus the professor of logic died of shame because he could not at once
solve a problem put to him in jest by Stilpo.
--- Pliny the Elder
This archive was generated by hypermail 2b25 : Thu Jan 25 2001 - 04:39:57 CST