Subject: Re: patch: Unix keboard handler UTF-8 support
From: Tomas Frydrych (tomas@frydrych.uklinux.net)
Date: Wed Jan 24 2001 - 14:25:56 CST
Hi Dom,
I have removed the offending include file and changed the two
occurences of KeySym to UT_uint32. An updated patch is
attached.
Tomas
> There's only one thing that makes me wary about this patch:
> #include <X11/X.h>
>
> Please don't do this to just get a definition for the KeySym type,
> especially if you're passing a GdkEvent->keyval to your keysym2ucs function.
> GdkEvent->keyval is a guint guaranteed to be 32 bits and unsigned (a
> UT_uint32 in AbiWord terminology). For future reference, *no* X11 headers
> ever get included in AbiWord Unix code.
>
> So, if you remove the #include <X11/X11.h> and change the definition of
> keysym2ucs to one of the following new definitions, I'll commit your patch:
>
> UT_sint32 keysym2ucs(guint keysym);
> or
> UT_sint32 keysyn2ucs(UT_uint32 keysym);
>
> Thanks,
> Dom
> _________________________________________________________________
> Get your FREE download of MSN Explorer at http://explorer.msn.com
>
>
*********************************************
tomas@frydrych.net / www.frydrych.net
PGP keys: http://www.frydrych.net/contact.html
The following section of this message contains a file attachment
prepared for transmission using the Internet MIME message format.
If you are using Pegasus Mail, or any another MIME-compliant system,
you should be able to save it or view it from within your mailer.
If you cannot, please ask your system administrator for assistance.
---- File information -----------
File: utf8kbd_patch.gz
Date: 24 Jan 2001, 21:15
Size: 16817 bytes.
Type: Unknown
This archive was generated by hypermail 2b25 : Wed Jan 24 2001 - 14:31:40 CST