Subject: Re: Windows build mystery solved
From: Sam TH (sam@uchicago.edu)
Date: Wed Jan 24 2001 - 12:13:52 CST
On Wed, Jan 24, 2001 at 12:26:39PM -0500, Tom Briggs wrote:
>
> I finally managed to track down the cause of the problems on Windows. (And
> there was much rejoicing... yay.)
>
> On line 540 of abi/src/config/abi_defs.mk is the following:
>
> CFLAGS += -I$(ABI_ROOT)/../psiconv
>
> This breaks compilation of ms-ole.c in the wv tree because the config.h
> that exists in the psiconv directory is #included instead of the config.h
> in the wv directory. (This happens because ms-ole.c is built from a
> subdirectory; thus the config.h that ms-ole.c wants is really "../config.h",
> not just "config.h".)
>
> This change was commited on the 18th as part of Frodo's psiconv work;
> I'm therefore lax to change anything because I don't know anything about how
> psiconv is compiled into Abi. It doesn't appear that any of the other modules'
> directories are forced into the general abi include path, so on basic
> principal I have to wonder if removing it from the global CFLAGS isn't the right
> thing to do. The only other thing I can think of is to force ms-ole.c to
> include ../config.h, but that seems like a really poor hack.
>
> Lemme know if none of this makes sense; I'm not feeling too well today, and
> I don't really feel like I'm explaining myself very well. :)
I think (without actually testing) that we would just have to add a
line like this
CFLAGS += -I../
to the Makefile in wv/libole2/ in order to override the config.h
inclusion.
Can you test that?
sam th
sam@uchicago.edu
http://www.abisource.com/~sam/
GnuPG Key:
http://www.abisource.com/~sam/key
This archive was generated by hypermail 2b25 : Wed Jan 24 2001 - 12:14:34 CST