Re: Abi crashers

Subject: Re: Abi crashers
From: Dom Lachowicz (doml@appligent.com)
Date: Mon Dec 17 2001 - 08:29:38 CST

• sorted by: [ date ] [ thread ] [ subject ] [ author ]
• Next message: Jesper Skov: "commit - fewer papersize changes"
• Previous message: Rui Miguel Seabra: "Re: More italian strings [commit]"
• In reply to: Robert Wilhelm: "Re: Abi crashers"
• Next in thread: Dom Lachowicz: "Re: Abi crashers"
• Reply: Dom Lachowicz: "Re: Abi crashers"

> The reason for this crash seems to be that in wv/libole2/ms-ole.c
> msole-lseek() is broken:
> In case MsOleSeekCur newpos is used uninitialised.
> Additional the case SeekEnd was also wrong.
>
> This is alread fixed in the libole2 at cvs.gnome.org:
>
>
> @@ -2146,13 +2105,13 @@ ms_ole_lseek (MsOleStream *s, MsOleSPos
> g_return_val_if_fail (s, -1);
>
> if (type == MsOleSeekSet)
> - newpos = bytes;
> + newpos = bytes;
> else if (type == MsOleSeekCur)
> - newpos += bytes;
> + newpos = s->position + bytes;
> else
> - newpos = s->size - bytes;
> + newpos = s->size + bytes;
>

Thanks a _lot_. This is committed.

Dom

• Next message: Jesper Skov: "commit - fewer papersize changes"
• Previous message: Rui Miguel Seabra: "Re: More italian strings [commit]"
• In reply to: Robert Wilhelm: "Re: Abi crashers"
• Next in thread: Dom Lachowicz: "Re: Abi crashers"
• Reply: Dom Lachowicz: "Re: Abi crashers"

This archive was generated by hypermail 2b25 : Mon Dec 17 2001 - 08:28:26 CST