Subject: Re: some incorret asserts in AW
From: Dom Lachowicz (cinamod@hotmail.com)
Date: Thu Oct 26 2000 - 03:04:25 CDT
I think that this goes deeper:
A lot of code in places has UT_ASSERT in them, when I think they want
behavior more like g_return(_val)_if_fail that glib provides. UT_Vector
displays this nicely. Anyone agree/disagree or mind if I go through and
maybe make a couple of new macros more like the glib ones and use them
incrementally in the codebase?
Dom
#define UT_RETURN_IF_FAIL(x) do { if(!(x)) { \
UT_DEBUGMSG(("Assertion failed file %s line %d\n", __FILE__, __LINE__));
\
return; \
}} while(0)
#define UT_RETURN_VAL_IF_FAIL(x,v) do {if(!(x)) {\
UT_DEBUGMSG(("Assertion failed file %s line %d\n", __FILE__, __LINE__));\
return(v); \
}} while (0)
>From: Vlad Harchev <hvv@hippo.ru>
>To: abiword-dev@abisource.com
>Subject: some incorret asserts in AW
>Date: Thu, 26 Oct 2000 12:25:18 +0500 (SAMST)
>
>
> I think stability of AW could be greatly improved if several asserts were
>using correct expressions to be asserted.
> Here are asserts that are violated when pressing some key sequences in
>empty
>document.
>
>* Pressing Backspace :
> (0) at fl_DocLayout.cpp:443
>
>* Pressing shift-{left,right} arrow in empty document:
> m_bCursorIsOn == UT_FALSE at fv_View.cpp:4731
>
>* Pressing enter, up, delete:
> m_iCount > 0 at ut_vector.cpp:200
>
>* pressing enter, backspace:
> m_iCount > 0 at ut_vector.cpp:200
>
> Could someone fix these?
>
> I'm currently using "yes | abiword" to get rock-solid AW (works if
>it's compiled with debug enabled) :)
>
> Best regards,
> -Vlad
>
>
_________________________________________________________________________
Get Your Private, Free E-mail from MSN Hotmail at http://www.hotmail.com.
Share information about yourself, create your own public profile at
http://profiles.msn.com.
This archive was generated by hypermail 2b25 : Thu Oct 26 2000 - 03:04:27 CDT