Subject: commit -- Patch: fix 0.7.10 compilation
From: Aaron Lehmann (aaronl@vitelus.com)
Date: Fri Jun 16 2000 - 16:54:28 CDT
Thanks bero for keeping AbiWord compiling with cutting-edge software!
CVS:
----------------------------------------------------------------------
CVS: Enter Log. Lines beginning with `CVS:' are removed automatically
CVS:
CVS: Committing in .
CVS:
CVS: Modified Files:
CVS: src/af/ev/unix/gnome/ev_UnixGnomeMenu.cpp
CVS: src/af/xap/unix/gnome/xap_UnixGnomeFrame.cpp
CVS:
----------------------------------------------------------------------
A
On Fri, 16 Jun 2000, Bernhard Rosenkraenzer wrote:
> Hi,
> Out of the box, 0.7.10 doesn't compile on gcc 2.96 systems.
> I've submitted this patch before, but apparently it didn't get in because
> it makes the code look a bit ugly...
>
> There's a lot of stuff like
>
> if (strncmp (str, "Ctrl+", 5) == 0) {
> - ac_mods |= GDK_CONTROL_MASK;
> + ac_mods = (GdkModifierType)(ac_mods|GDK_CONTROL_MASK);
> str += 5;
> }
>
> This stuff looks like nonsense, but gcc 2.96 won't accept the nice
> (==old) version, because GdkModifierType|GdkModifierType==int and int
> isn't auto-converted to GdkModifierType.
>
> I'm not 100% sure if this is standards compliance or a gcc bug; in any
> case, the ugly (==new) version does the same and works with gcc 2.96.
>
> LLaP
> bero
>
>
This archive was generated by hypermail 2b25 : Fri Jun 16 2000 - 16:54:39 CDT